Fix: Display full changelog #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvaje
approved these changes
Sep 17, 2019
antross
reviewed
Sep 17, 2019
molant
force-pushed
the
fix/changelog
branch
from
4ff36db to
ce1791f
Compare
The project had different versions of the same package because of how hoisting works, `hint`'s `optionalDependencies` (the configurations are not the latest ones) and how npm handles duplicates and `package-lock.json`. By removing `package-lock.json` npm will always go fetch the latest version of the packages and avoid these issues. Also all packages will be installed in `node_modules` and not inside another folder under it. Because multiple versions of the same package, the changelog was not always accurate. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix webhintio#825
molant
force-pushed
the
fix/changelog
branch
from
ce1791f to
45b5c3d
Compare
antross
reviewed
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
Short description of the change(s)
The project had different versions of the same package because of how
hoisting works,
hint'soptionalDependencies(the configurations arenot the latest ones) and how npm handles duplicates and
package-lock.json.By removing
package-lock.jsonnpm will always go fetch the latestversion of the packages and avoid these issues. Also all packages will
be installed in
node_modulesand not inside another folder under it.Because multiple versions of the same package, the changelog was not
always accurate.
Fix #825